Fixing sonarcloud issues

This commit is contained in:
2025-06-19 19:29:05 +02:00
parent 1fc8e6cc1c
commit e03db76496
62 changed files with 152 additions and 129 deletions

View File

@@ -53,4 +53,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
}
}
}

View File

@@ -74,4 +74,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
#nullable disable
}
}
}

View File

@@ -67,9 +67,9 @@ namespace BasicDotnetTemplate.MainProject.Controllers
{
try
{
if (await this._roleService.CheckIfNameIsValid(request.Data.Name))
if (await this._roleService.CheckIfNameIsValid(request!.Data!.Name))
{
var role = await this._roleService.CreateRoleAsync(request.Data);
var role = await this._roleService.CreateRoleAsync(request!.Data);
if (role == null || String.IsNullOrEmpty(role.Guid))
{
@@ -121,8 +121,8 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
if (
await this._roleService.CheckIfNameIsValid(request.Data.Name) ||
await this._roleService.CheckIfNameIsValid(request.Data.Name, guid)
await this._roleService.CheckIfNameIsValid(request!.Data!.Name) ||
await this._roleService.CheckIfNameIsValid(request!.Data!.Name, guid)
)
{
role = await this._roleService.UpdateRoleAsync(request.Data, role);
@@ -167,7 +167,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return NotFound();
}
await this._roleService.DeleteRoleAsync(role);
await this._roleService.DeleteRoleAsync(role);
return Success(String.Empty);
}
@@ -185,4 +185,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
}
}

View File

@@ -15,4 +15,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return Ok();
}
}
}
}

View File

@@ -25,7 +25,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
this._userService = userService;
this._roleService = roleService;
}
[JwtAuthorization()]
[ModelStateValidationHandledByFilterAttribute]
@@ -73,13 +73,13 @@ namespace BasicDotnetTemplate.MainProject.Controllers
{
if (await this._userService.CheckIfEmailIsValid(request!.Data!.Email))
{
var role = await this._roleService.GetRoleForUser(request.Data.RoleGuid);
var role = await this._roleService.GetRoleForUser(request!.Data!.RoleGuid);
if (role == null)
{
return BadRequest("Role not found");
}
var user = await this._userService.CreateUserAsync(request.Data, role);
var user = await this._userService.CreateUserAsync(request!.Data, role);
if (user == null || String.IsNullOrEmpty(user.Guid))
{
@@ -119,7 +119,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
try
{
var user = await this._userService.GetUserByGuidAsync(guid);
if(user == null)
if (user == null)
{
return NotFound();
}
@@ -129,7 +129,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
var userDto = _mapper?.Map<UserDto>(user);
return Success(String.Empty, userDto);
}
catch (Exception exception)
{
@@ -141,7 +141,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return InternalServerError(message);
}
}
}
[JwtAuthorization()]
[ModelStateValidationHandledByFilterAttribute]
@@ -154,7 +154,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
try
{
var user = await this._userService.GetUserByGuidAsync(guid);
if(user == null)
if (user == null)
{
return NotFound();
}
@@ -164,7 +164,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
var userDto = _mapper?.Map<UserDto>(user);
return Success(String.Empty, userDto);
}
catch (Exception exception)
{
@@ -176,7 +176,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return InternalServerError(message);
}
}
}
[JwtAuthorization()]
[ModelStateValidationHandledByFilterAttribute]
@@ -195,7 +195,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
var user = await this._userService.GetUserByGuidAsync(guid);
if(user == null)
if (user == null)
{
return NotFound();
}
@@ -205,7 +205,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
var userDto = _mapper?.Map<UserDto>(user);
return Success(String.Empty, userDto);
}
catch (Exception exception)
{
@@ -217,8 +217,8 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return InternalServerError(message);
}
}
}
[JwtAuthorization()]
[ModelStateValidationHandledByFilterAttribute]
[HttpDelete("{guid}")]
@@ -239,7 +239,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
await this._userService.DeleteUserAsync(user);
return Success(String.Empty);
return Success(String.Empty);
}
catch (Exception exception)
{
@@ -254,4 +254,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
}
}
}

View File

@@ -16,4 +16,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return Success(String.Empty, _appSettings?.Settings?.Version);
}
}
}
}