simona/dotnet-template
Template
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing sonarcloud issues

Browse Source
This commit is contained in:
Caterina Simona Pastore
2025-06-19 19:29:05 +02:00
parent 1fc8e6cc1c
commit e03db76496
62 changed files with 152 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
MainProject/Controllers/AuthController.cs
View File

@@ -53,4 +53,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
}
}
}

2
MainProject/Controllers/BaseController.cs
View File

@@ -74,4 +74,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
#nullable disable
}
}
}

12
MainProject/Controllers/RoleController.cs
View File

@@ -67,9 +67,9 @@ namespace BasicDotnetTemplate.MainProject.Controllers
{
try
{
if (await this._roleService.CheckIfNameIsValid(request.Data.Name))
if (await this._roleService.CheckIfNameIsValid(request!.Data!.Name))
{
var role = await this._roleService.CreateRoleAsync(request.Data);
var role = await this._roleService.CreateRoleAsync(request!.Data);
if (role == null || String.IsNullOrEmpty(role.Guid))
{
@@ -121,8 +121,8 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
if (
await this._roleService.CheckIfNameIsValid(request.Data.Name) ||
await this._roleService.CheckIfNameIsValid(request.Data.Name, guid)
await this._roleService.CheckIfNameIsValid(request!.Data!.Name) ||
await this._roleService.CheckIfNameIsValid(request!.Data!.Name, guid)
)
{
role = await this._roleService.UpdateRoleAsync(request.Data, role);
@@ -167,7 +167,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return NotFound();
}
await this._roleService.DeleteRoleAsync(role);
await this._roleService.DeleteRoleAsync(role);
return Success(String.Empty);
}
@@ -185,4 +185,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
}
}

2
MainProject/Controllers/RootController.cs
View File

@@ -15,4 +15,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return Ok();
}
}
}
}

30
MainProject/Controllers/UserController.cs
View File

@@ -25,7 +25,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
this._userService = userService;
this._roleService = roleService;
}
[JwtAuthorization()]
[ModelStateValidationHandledByFilterAttribute]
@@ -73,13 +73,13 @@ namespace BasicDotnetTemplate.MainProject.Controllers
{
if (await this._userService.CheckIfEmailIsValid(request!.Data!.Email))
{
var role = await this._roleService.GetRoleForUser(request.Data.RoleGuid);
var role = await this._roleService.GetRoleForUser(request!.Data!.RoleGuid);
if (role == null)
{
return BadRequest("Role not found");
}
var user = await this._userService.CreateUserAsync(request.Data, role);
var user = await this._userService.CreateUserAsync(request!.Data, role);
if (user == null || String.IsNullOrEmpty(user.Guid))
{
@@ -119,7 +119,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
try
{
var user = await this._userService.GetUserByGuidAsync(guid);
if(user == null)
if (user == null)
{
return NotFound();
}
@@ -129,7 +129,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
var userDto = _mapper?.Map<UserDto>(user);
return Success(String.Empty, userDto);
}
catch (Exception exception)
{
@@ -141,7 +141,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return InternalServerError(message);
}
}
}
[JwtAuthorization()]
[ModelStateValidationHandledByFilterAttribute]
@@ -154,7 +154,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
try
{
var user = await this._userService.GetUserByGuidAsync(guid);
if(user == null)
if (user == null)
{
return NotFound();
}
@@ -164,7 +164,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
var userDto = _mapper?.Map<UserDto>(user);
return Success(String.Empty, userDto);
}
catch (Exception exception)
{
@@ -176,7 +176,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return InternalServerError(message);
}
}
}
[JwtAuthorization()]
[ModelStateValidationHandledByFilterAttribute]
@@ -195,7 +195,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
var user = await this._userService.GetUserByGuidAsync(guid);
if(user == null)
if (user == null)
{
return NotFound();
}
@@ -205,7 +205,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
var userDto = _mapper?.Map<UserDto>(user);
return Success(String.Empty, userDto);
}
catch (Exception exception)
{
@@ -217,8 +217,8 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return InternalServerError(message);
}
}
}
[JwtAuthorization()]
[ModelStateValidationHandledByFilterAttribute]
[HttpDelete("{guid}")]
@@ -239,7 +239,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
await this._userService.DeleteUserAsync(user);
return Success(String.Empty);
return Success(String.Empty);
}
catch (Exception exception)
{
@@ -254,4 +254,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
}
}
}
}

2
MainProject/Controllers/VersionController.cs
View File

@@ -16,4 +16,4 @@ namespace BasicDotnetTemplate.MainProject.Controllers
return Success(String.Empty, _appSettings?.Settings?.Version);
}
}
}
}

2
MainProject/Core/Attributes/ValidateModelStateAutomaticallyAttribute.cs
View File

@@ -9,4 +9,4 @@ namespace BasicDotnetTemplate.MainProject.Core.Attributes
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false, Inherited = true)]
public class ModelStateValidationHandledByFilterAttribute : Attribute
{ }
}
}

2
MainProject/Core/Database/SqlServerContext.cs
View File

@@ -18,7 +18,7 @@ namespace BasicDotnetTemplate.MainProject.Core.Database
public DbSet<PermissionOperation> PermissionOperations { get; set; }
public DbSet<PermissionSystem> PermissionSystems { get; set; }
public DbSet<PermissionSystemModule> PermissionSystemModules { get; set; }
public DbSet<PermissionSystemModuleOperation> PermissionSystemModuleOperations { get; set; }
public DbSet<PermissionSystemModuleOperation> PermissionSystemModuleOperations { get; set; }
public DbSet<RolePermissionSystemModuleOperation> RolePermissionSystemModuleOperations { get; set; }
public DbSet<Role> Roles { get; set; }
public DbSet<User> Users { get; set; }

4
MainProject/Core/Filters/ValidationActionFilter.cs
View File

@@ -13,7 +13,7 @@ namespace BasicDotnetTemplate.MainProject.Core.Filters
if (!context.ModelState.IsValid)
{
context.Result = new BadRequestObjectResult(new { message = _requestNotWellFormedMessage, errors = context.ModelState });
return;
return;
}
var requestBody = context.ActionArguments.Values.FirstOrDefault(arg => arg != null && !arg.GetType().IsPrimitive && !(arg is string));
@@ -27,4 +27,4 @@ namespace BasicDotnetTemplate.MainProject.Core.Filters
await next();
}
}
}
}

2
MainProject/Migrations/20240904211920_InitialCreate.cs
View File

@@ -1,4 +1,4 @@
using System;
using System;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Migrations/20241129231345_Try.cs
View File

@@ -1,4 +1,4 @@
using Microsoft.EntityFrameworkCore.Migrations;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Migrations/20250311195750_AlterTableUser.cs
View File

@@ -1,4 +1,4 @@
using Microsoft.EntityFrameworkCore.Migrations;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Migrations/20250312234517_AlterTableUserMaxLengthIndexes.cs
View File

@@ -1,4 +1,4 @@
using Microsoft.EntityFrameworkCore.Migrations;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Migrations/20250316014620_AlterTablesUsersAndRoles.cs
View File

@@ -1,4 +1,4 @@
using Microsoft.EntityFrameworkCore.Migrations;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Migrations/20250316212343_AlterBaseUpdateTimeDeletionTimeNullable.cs
View File

@@ -1,4 +1,4 @@
using System;
using System;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Migrations/20250316212722_AlterTableRoleAddedIsNotEditable.cs
View File

@@ -1,4 +1,4 @@
using Microsoft.EntityFrameworkCore.Migrations;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Migrations/20250426183010_AddingPermissionsTables.cs
View File

@@ -1,4 +1,4 @@
using System;
using System;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Migrations/20250617183212_AlterTableUsersForPasswordEncryption.cs
View File

@@ -1,4 +1,4 @@
using Microsoft.EntityFrameworkCore.Migrations;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable

2
MainProject/Models/Api/Common/Role/UserRole.cs
View File

@@ -9,7 +9,7 @@ public class UserRole
public string? Name { get; set; }
#nullable disable
public UserRole() {}
public UserRole() { }
public UserRole(DatabaseSqlServer.Role role)
{

2
MainProject/Models/Api/Data/Role/CreateRoleRequestData.cs
View File

@@ -8,4 +8,4 @@ public class CreateRoleRequestData
public required string Name { get; set; }
public required bool IsNotEditable { get; set; }
}
}

2
MainProject/Models/Api/Request/Role/CreateRoleRequest.cs
View File

@@ -7,4 +7,4 @@ public class CreateRoleRequest
#nullable enable
public CreateRoleRequestData? Data { get; set; }
#nullable disable
}
}

2
MainProject/Models/Api/Response/Auth/AuthenticateResponse.cs
View File

@@ -5,4 +5,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Api.Response.Auth;
public class AuthenticateResponse : BaseResponse<AuthenticatedUser>
{
public AuthenticateResponse(int status, string? message, AuthenticatedUser? data) : base(status, message, data) { }
}
}

2
MainProject/Models/Api/Response/BaseResponse.cs
View File

@@ -16,4 +16,4 @@ public class BaseResponse<T>
public virtual dynamic? Data { get; set; }
#nullable disable
}
}

2
MainProject/Models/Api/Response/Role/GetRoleResponse.cs
View File

@@ -5,4 +5,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Api.Response.Role;
public class GetRoleResponse : BaseResponse<RoleDto>
{
public GetRoleResponse(int status, string? message, RoleDto? data) : base(status, message, data) { }
}
}

2
MainProject/Models/Api/Response/User/GetUserResponse.cs
View File

@@ -5,4 +5,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Api.Response.User;
public class GetUserResponse : BaseResponse<UserDto>
{
public GetUserResponse(int status, string? message, UserDto? data) : base(status, message, data) { }
}
}

4
MainProject/Models/Common/OperationInfo.cs
View File

@@ -4,6 +4,6 @@ public class OperationInfo
{
#nullable enable
public string? Operation { get; set; }
public List<string>? Roles {get; set; }
public List<string>? Roles { get; set; }
#nullable disable
}
}

4
MainProject/Models/Common/PermissionInfo.cs
View File

@@ -4,6 +4,6 @@ public class PermissionInfo
{
#nullable enable
public string? System { get; set; }
public List<RolePermissionModuleOperation>? RolePermissionModuleOperations {get; set; }
public List<RolePermissionModuleOperation>? RolePermissionModuleOperations { get; set; }
#nullable disable
}
}

2
MainProject/Models/Common/PermissionsFile.cs
View File

@@ -5,4 +5,4 @@ public class PermissionsFile
#nullable enable
public List<PermissionInfo>? PermissionInfos { get; set; }
#nullable disable
}
}

2
MainProject/Models/Common/RolePermissionModuleOperation.cs
View File

@@ -6,4 +6,4 @@ public class RolePermissionModuleOperation
public string? Module { get; set; }
public List<OperationInfo>? Operations { get; set; }
#nullable disable
}
}

2
MainProject/Models/Database/Mongo/Log.cs
View File

@@ -8,4 +8,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Database.Mongo
[BsonId]
public ObjectId Id { get; set; }
}
}
}

2
MainProject/Models/Database/SqlServer/PermissionModule.cs
View File

@@ -8,4 +8,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Database.SqlServer
public required string Name { get; set; }
public required bool Enabled { get; set; }
}
}
}

2
MainProject/Models/Database/SqlServer/PermissionOperation.cs
View File

@@ -7,4 +7,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Database.SqlServer
[MaxLength(100)]
public required string Name { get; set; }
}
}
}

2
MainProject/Models/Database/SqlServer/PermissionSystem.cs
View File

@@ -8,4 +8,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Database.SqlServer
public required string Name { get; set; }
public required bool Enabled { get; set; }
}
}
}

2
MainProject/Models/Database/SqlServer/PermissionSystemModule.cs
View File

@@ -10,4 +10,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Database.SqlServer
public required PermissionModule PermissionModule { get; set; }
public required bool Enabled { get; set; }
}
}
}

2
MainProject/Models/Database/SqlServer/PermissionSystemModuleOperation.cs
View File

@@ -10,4 +10,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Database.SqlServer
public required PermissionSystemModule PermissionSystemModule { get; set; }
public required PermissionOperation PermissionOperation { get; set; }
}
}
}

2
MainProject/Models/Database/SqlServer/RolePermissionSystemModuleOperation.cs
View File

@@ -10,4 +10,4 @@ namespace BasicDotnetTemplate.MainProject.Models.Database.SqlServer
public required Role Role { get; set; }
public required PermissionSystemModuleOperation PermissionSystemModuleOperation { get; set; }
}
}
}

2
MainProject/Models/Settings/AppSettings.cs
View File

@@ -11,4 +11,4 @@ public class AppSettings
public EncryptionSettings? EncryptionSettings { get; set; }
public PermissionsSettings? PermissionsSettings { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/DatabaseConnection.cs
View File

@@ -7,4 +7,4 @@ public class DatabaseConnection
public string? Postgres { get; set; }
public string? Mongodb { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/DatabaseSettings.cs
View File

@@ -7,4 +7,4 @@ public class DatabaseSettings
public string? MongoDbConnectionString { get; set; }
public string? PostgreSQLConnectionString { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/EncryptionSettings.cs
View File

@@ -7,4 +7,4 @@ public class EncryptionSettings
public string? Salt { get; set; }
public int? Iterations { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/JwtSettings.cs
View File

@@ -9,4 +9,4 @@ public class JwtSettings
public int? ExpiredAfterMinsOfInactivity { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/OpenApiSettings.cs
View File

@@ -7,4 +7,4 @@ public class OpenApiSettings
public OpenApiSettingsDetails? OpenApiContact { get; set; }
public OpenApiSettingsDetails? OpenApiLicense { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/OpenApiSettingsDetails.cs
View File

@@ -6,4 +6,4 @@ public class OpenApiSettingsDetails
public string? Name { get; set; }
public string? Url { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/PermissionsSettings.cs
View File

@@ -5,4 +5,4 @@ public class PermissionsSettings
#nullable enable
public string? FilePath { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/PrivateSettings.cs
View File

@@ -5,4 +5,4 @@ public class PrivateSettings
#nullable enable
public DatabaseConnection? DatabaseConnection { get; set; }
#nullable disable
}
}

2
MainProject/Models/Settings/Settings.cs
View File

@@ -7,4 +7,4 @@ public class Settings
public string? Version { get; set; }
public string? Description { get; set; }
#nullable disable
}
}

4
MainProject/Program.cs
View File

@@ -1,4 +1,4 @@
using NLog;
using NLog;
using BasicDotnetTemplate.MainProject.Models.Settings;
using System.Reflection;
using BasicDotnetTemplate.MainProject.Utils;
@@ -60,4 +60,4 @@ internal static class Program
NLog.LogManager.Shutdown(); // Flush and close down internal threads and timers
}
}
}

2
MainProject/Services/PermissionService.cs
View File

@@ -1275,4 +1275,4 @@ public class PermissionService : BaseService, IPermissionService
}
}

2
MainProject/Services/UserService.cs
View File

@@ -191,7 +191,7 @@ public class UserService : BaseService, IUserService
user.PasswordSalt = salt;
user.PasswordPepper = pepper;
user.PasswordIterations = iterations;
user.PasswordIterations = iterations;
user.Password = CryptUtils.GeneratePassword(newPassword, salt, iterations, pepper);
user.UpdateTime = DateTime.UtcNow;
user.UpdateUserId = this.GetCurrentUserId();

2
MainProject/Utils/FileUtils.cs
View File

@@ -39,4 +39,4 @@ public static class FileUtils
}
}
}
}

2
MainProject/Utils/PasswordUtils.cs
View File

@@ -29,7 +29,7 @@ public static partial class PasswordUtils
private static partial Regex RegexSpecial();
private static readonly Regex RegexIdenticalChars = new(
@"(\S)\1{2,}",
@"(\S)\1{2,}",
RegexOptions.IgnoreCase | RegexOptions.Compiled,
TimeSpan.FromMilliseconds(100)
);

4
MainProject/Utils/ProgramUtils.cs
View File

@@ -142,7 +142,7 @@ public static class ProgramUtils
builder.Services.AddAuthorization();
builder.Services.AddControllers(options =>
{
options.Filters.Add<ValidationActionFilter>();
options.Filters.Add<ValidationActionFilter>();
});
builder.Services.AddEndpointsApiExplorer();
@@ -295,4 +295,4 @@ public static class ProgramUtils
}
}
}
}