From a8e51fa6b57c8d4f4d503a50e3c41d183de291c5 Mon Sep 17 00:00:00 2001 From: csimonapastore Date: Thu, 20 Mar 2025 23:34:56 +0100 Subject: [PATCH] Fixing coverage --- .../Services/UserService_Tests.cs | 220 +++--------------- 1 file changed, 31 insertions(+), 189 deletions(-) diff --git a/MainProject.Tests/Services/UserService_Tests.cs b/MainProject.Tests/Services/UserService_Tests.cs index b56dda2..486a4bf 100644 --- a/MainProject.Tests/Services/UserService_Tests.cs +++ b/MainProject.Tests/Services/UserService_Tests.cs @@ -9,9 +9,6 @@ namespace BasicDotnetTemplate.MainProject.Tests; [TestClass] public class UserService_Tests { - private static User _user = ModelsInit.CreateUser(); - private static Role _role = ModelsInit.CreateRole(); - [TestMethod] public void Inizialize() { @@ -34,36 +31,6 @@ public class UserService_Tests } } - // [TestInitialize] - // public void Setup() - // { - // _expectedUser = ModelsInit.CreateUser(); - // _expectedRole = ModelsInit.CreateRole(); - // _roleService = TestUtils.CreateRoleService(); - // _userService = TestUtils.CreateUserService(); - // } - - // [TestMethod] - // public void Inizialize() - // { - // try - // { - // if (_userService != null) - // { - // Assert.IsInstanceOfType(_userService, typeof(UserService)); - // } - // else - // { - // Assert.Fail($"UserService is null"); - // } - // } - // catch (Exception ex) - // { - // Console.WriteLine(ex.InnerException); - // Assert.Fail($"An exception was thrown: {ex}"); - // } - // } - [TestMethod] public async Task GetUserByUsernameAndPassword_Null() { @@ -114,37 +81,18 @@ public class UserService_Tests // } // } - [TestMethod] - public async Task CheckIfEmailIsValid_EmailNotExists() - { - try - { - var userService = TestUtils.CreateUserService(); - if (userService != null) - { - var valid = await userService.CheckIfEmailIsValid(_user.Email ?? String.Empty); - Assert.IsTrue(valid); - } - else - { - Assert.Fail($"UserService is null"); - } - } - catch (Exception ex) - { - Console.WriteLine(ex.InnerException); - Assert.Fail($"An exception was thrown: {ex}"); - } - } - [TestMethod] public async Task CreateUserAsync_Success() { try { var userService = TestUtils.CreateUserService(); + var roleService = TestUtils.CreateRoleService(); var expectedUser = ModelsInit.CreateUser(); + var valid = await userService.CheckIfEmailIsValid(expectedUser.Email ?? String.Empty); + Assert.IsTrue(valid); + CreateUserRequestData data = new CreateUserRequestData() { FirstName = expectedUser.FirstName ?? String.Empty, @@ -166,9 +114,34 @@ public class UserService_Tests Assert.IsTrue(expectedUser.LastName == user.LastName); Assert.IsTrue(expectedUser.Email == user.Email); Assert.IsTrue(expectedUser.Role?.Name == user.Role?.Name); - _user = user; - _role = user.Role; + var user_role = await roleService.GetRoleByGuidAsync(user.Role?.Guid ?? String.Empty); + + + valid = await userService.CheckIfEmailIsValid(user.Email, user.Guid); + Assert.IsTrue(valid); + + valid = await userService.CheckIfEmailIsValid(user.Email, Guid.NewGuid().ToString()); + Assert.IsFalse(valid); + + + var user_by_id = await userService.GetUserByIdAsync(user.Id); + Assert.IsNotNull(user_by_id); + Assert.IsTrue(user.Id == user_by_id.Id); + + + var user_by_guid = await userService.GetUserByGuidAsync(user.Guid); + Assert.IsNotNull(user_by_guid); + Assert.IsTrue(user.Guid == user_by_guid.Guid); + + + var deleted = await userService.DeleteUserAsync(user); + Assert.IsTrue(deleted); + + + Assert.IsNotNull(user_role); + deleted = await roleService.DeleteRoleAsync(user_role); + Assert.IsTrue(deleted); } catch (Exception ex) { @@ -177,137 +150,6 @@ public class UserService_Tests } } - [TestMethod] - public async Task CheckIfEmailIsValid_EmailCurrentUser() - { - try - { - var userService = TestUtils.CreateUserService(); - if (userService != null) - { - var valid = await userService.CheckIfEmailIsValid(_user.Email ?? String.Empty, _user.Guid ?? String.Empty); - Assert.IsTrue(valid); - } - else - { - Assert.Fail($"UserService is null"); - } - } - catch (Exception ex) - { - Console.WriteLine(ex.InnerException); - Assert.Fail($"An exception was thrown: {ex}"); - } - } - - [TestMethod] - public async Task CheckIfEmailIsValid_EmailAlreadyExists() - { - try - { - var userService = TestUtils.CreateUserService(); - if (userService != null) - { - var valid = await userService.CheckIfEmailIsValid(_user.Email ?? String.Empty); - Assert.IsFalse(valid); - } - else - { - Assert.Fail($"UserService is null"); - } - } - catch (Exception ex) - { - Console.WriteLine(ex.InnerException); - Assert.Fail($"An exception was thrown: {ex}"); - } - } - - [TestMethod] - public async Task GetUserByIdAsync() - { - try - { - var userService = TestUtils.CreateUserService(); - if (userService != null) - { - var user = await userService.GetUserByIdAsync(_user.Id); - Assert.IsNotNull(user); - Assert.IsTrue(user.Id == _user?.Id); - } - else - { - Assert.Fail($"UserService is null"); - } - } - catch (Exception ex) - { - Console.WriteLine(ex.InnerException); - Assert.Fail($"An exception was thrown: {ex}"); - } - } - - [TestMethod] - public async Task GetUserByGuidAsync() - { - try - { - var userService = TestUtils.CreateUserService(); - if (userService != null) - { - var user = await userService.GetUserByGuidAsync(_user.Guid ?? String.Empty); - Assert.IsNotNull(user); - Assert.IsTrue(user.Guid == _user?.Guid); - } - else - { - Assert.Fail($"UserService is null"); - } - } - catch (Exception ex) - { - Console.WriteLine(ex.InnerException); - Assert.Fail($"An exception was thrown: {ex}"); - } - } - - [TestMethod] - public async Task DeleteUser() - { - try - { - var userService = TestUtils.CreateUserService(); - if (userService != null) - { - var user = await userService.GetUserByGuidAsync(_user.Guid ?? String.Empty); - Assert.IsNotNull(user); - var deleted = await userService.DeleteUserAsync(user); - Assert.IsTrue(deleted); - } - else - { - Assert.Fail($"UserService is null"); - } - } - catch (Exception ex) - { - Console.WriteLine(ex.InnerException); - Assert.Fail($"An exception was thrown: {ex}"); - } - } - - - - [TestMethod] - public static async Task CleanupAsync() - { - var roleService = TestUtils.CreateRoleService(); - var role = await roleService.GetRoleByGuidAsync(_role.Guid ?? String.Empty); - Assert.IsNotNull(role); - var deleted = await roleService.DeleteRoleAsync(role); - Assert.IsTrue(deleted); - } - }