Removing duplicated lines - wip

This commit is contained in:
2025-06-19 00:30:16 +02:00
parent e1a249c07a
commit 8bc50f8135
14 changed files with 581 additions and 626 deletions

View File

@@ -99,40 +99,40 @@ public class UserController_Tests
}
}
[TestMethod]
public async Task GetUserByGuidAsync_GuidIsEmpty()
{
if (_userController == null)
{
Assert.Fail($"_userController is null");
}
// [TestMethod]
// public async Task GetUserByGuidAsync_GuidIsEmpty()
// {
// if (_userController == null)
// {
// Assert.Fail($"_userController is null");
// }
var guid = String.Empty;
DatabaseSqlServer.User? user = null;
// var guid = String.Empty;
// DatabaseSqlServer.User? user = null;
_userServiceMock?.Setup(s => s.GetUserByGuidAsync(It.IsAny<string>())).ReturnsAsync(user);
ObjectResult response = (ObjectResult)(await _userController.GetUserByGuidAsync(guid));
// _userServiceMock?.Setup(s => s.GetUserByGuidAsync(It.IsAny<string>())).ReturnsAsync(user);
// ObjectResult response = (ObjectResult)(await _userController.GetUserByGuidAsync(guid));
if (response != null && response.Value != null)
{
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest);
// if (response != null && response.Value != null)
// {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest);
var result = (BaseResponse<object>)response.Value;
if (result != null)
{
Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
Assert.IsTrue(result.Message == "Request is not well formed");
}
else
{
Assert.Fail($"Result value is null");
}
}
else
{
Assert.Fail($"Response value is null");
}
}
// var result = (BaseResponse<object>)response.Value;
// if (result != null)
// {
// Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
// Assert.IsTrue(result.Message == "Request is not well formed");
// }
// else
// {
// Assert.Fail($"Result value is null");
// }
// }
// else
// {
// Assert.Fail($"Response value is null");
// }
// }
[TestMethod]
public async Task GetUserByGuidAsync_NotFound()
@@ -159,42 +159,42 @@ public class UserController_Tests
}
}
[TestMethod]
public async Task GetUserByGuidAsync_ModelInvalid()
{
if (_userController == null)
{
Assert.Fail($"_userController is null");
}
// [TestMethod]
// public async Task GetUserByGuidAsync_ModelInvalid()
// {
// if (_userController == null)
// {
// Assert.Fail($"_userController is null");
// }
var guid = Guid.NewGuid().ToString();
DatabaseSqlServer.User? user = null;
_userServiceMock?.Setup(s => s.GetUserByGuidAsync(It.IsAny<string>())).ReturnsAsync(user);
_userController.ModelState.AddModelError("Data", "Invalid data");
ObjectResult response = (ObjectResult)(await _userController.GetUserByGuidAsync(guid));
// var guid = Guid.NewGuid().ToString();
// DatabaseSqlServer.User? user = null;
// _userServiceMock?.Setup(s => s.GetUserByGuidAsync(It.IsAny<string>())).ReturnsAsync(user);
// _userController.ModelState.AddModelError("Data", "Invalid data");
// ObjectResult response = (ObjectResult)(await _userController.GetUserByGuidAsync(guid));
Assert.IsInstanceOfType(response, typeof(ObjectResult));
// Assert.IsInstanceOfType(response, typeof(ObjectResult));
if (response != null && response.Value != null)
{
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest);
// if (response != null && response.Value != null)
// {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest);
var result = (BaseResponse<object>)response.Value;
if (result != null)
{
Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
Assert.IsTrue(result.Message == "Request is not well formed");
}
else
{
Assert.Fail($"Result value is null");
}
}
else
{
Assert.Fail($"Response is null");
}
}
// var result = (BaseResponse<object>)response.Value;
// if (result != null)
// {
// Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
// Assert.IsTrue(result.Message == "Request is not well formed");
// }
// else
// {
// Assert.Fail($"Result value is null");
// }
// }
// else
// {
// Assert.Fail($"Response is null");
// }
// }
[TestMethod]
public async Task GetUserByGuidAsync_Exception()
@@ -381,50 +381,50 @@ public class UserController_Tests
}
}
[TestMethod]
public async Task CreateUserAsync_CreateUserRequestDataNull()
{
if (_userController == null)
{
Assert.Fail($"_userController is null");
}
// [TestMethod]
// public async Task CreateUserAsync_CreateUserRequestDataNull()
// {
// if (_userController == null)
// {
// Assert.Fail($"_userController is null");
// }
DatabaseSqlServer.User user = ModelsInit.CreateUser();
// DatabaseSqlServer.User user = ModelsInit.CreateUser();
CreateUserRequest request = new CreateUserRequest()
{
Data = null
};
// CreateUserRequest request = new CreateUserRequest()
// {
// Data = null
// };
_userServiceMock?.Setup(s => s.CheckIfEmailIsValid(It.IsAny<string>(), It.IsAny<string>())).ReturnsAsync(true);
// _userServiceMock?.Setup(s => s.CheckIfEmailIsValid(It.IsAny<string>(), It.IsAny<string>())).ReturnsAsync(true);
_userServiceMock?.Setup(s => s.CreateUserAsync(
It.IsAny<CreateUserRequestData>(),
It.IsAny<Role>()
)).ReturnsAsync(user);
// _userServiceMock?.Setup(s => s.CreateUserAsync(
// It.IsAny<CreateUserRequestData>(),
// It.IsAny<Role>()
// )).ReturnsAsync(user);
ObjectResult response = (ObjectResult)(await _userController.CreateUserAsync(request));
// ObjectResult response = (ObjectResult)(await _userController.CreateUserAsync(request));
if (response != null && response.Value != null)
{
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest);
// if (response != null && response.Value != null)
// {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest);
var result = (BaseResponse<object>)response.Value;
if (result != null)
{
Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
Assert.IsTrue(result.Message == "Request is not well formed");
}
else
{
Assert.Fail($"Result value is null");
}
}
else
{
Assert.Fail($"Response value is null");
}
}
// var result = (BaseResponse<object>)response.Value;
// if (result != null)
// {
// Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
// Assert.IsTrue(result.Message == "Request is not well formed");
// }
// else
// {
// Assert.Fail($"Result value is null");
// }
// }
// else
// {
// Assert.Fail($"Response value is null");
// }
// }
[TestMethod]
public async Task CreateUserAsync_NotCreated()
@@ -481,58 +481,59 @@ public class UserController_Tests
}
}
[TestMethod]
public async Task CreateUserAsync_ModelInvalid()
{
if (_userController == null)
{
Assert.Fail($"_userController is null");
}
// [TestMethod]
// public async Task CreateUserAsync_ModelInvalid()
// {
// if (_userController == null)
// {
// Assert.Fail($"_userController is null");
// }
DatabaseSqlServer.User user = ModelsInit.CreateUser();
// DatabaseSqlServer.User user = ModelsInit.CreateUser();
CreateUserRequest request = new CreateUserRequest()
{
Data = new CreateUserRequestData()
{
FirstName = user.FirstName,
LastName = user.LastName,
Email = user.Email,
Password = user.Password
}
};
// CreateUserRequest request = new CreateUserRequest()
// {
// Data = new CreateUserRequestData()
// {
// FirstName = user.FirstName,
// LastName = user.LastName,
// Email = user.Email,
// Password = user.Password
// }
// };
_userServiceMock?.Setup(s => s.CheckIfEmailIsValid(It.IsAny<string>(), It.IsAny<string>())).ReturnsAsync(true);
// _userServiceMock?.Setup(s => s.CheckIfEmailIsValid(It.IsAny<string>(), It.IsAny<string>())).ReturnsAsync(true);
_userServiceMock?.Setup(s => s.CreateUserAsync(
It.IsAny<CreateUserRequestData>(),
It.IsAny<Role>()
)).ReturnsAsync(user);
_userController.ModelState.AddModelError("Data", "Invalid data");
ObjectResult response = (ObjectResult)(await _userController.CreateUserAsync(request));
// _userServiceMock?.Setup(s => s.CreateUserAsync(
// It.IsAny<CreateUserRequestData>(),
// It.IsAny<Role>()
// )).ReturnsAsync(user);
// _userController.ModelState.AddModelError("Data", "Invalid data");
// ObjectResult response = (ObjectResult)(await _userController.CreateUserAsync(request));
Assert.IsInstanceOfType(response, typeof(ObjectResult));
// Assert.IsInstanceOfType(response, typeof(ObjectResult));
if (response != null && response.Value != null)
{
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest);
// if (response != null && response.Value != null)
// {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest);
var result = (BaseResponse<object>)response.Value;
if (result != null)
{
Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
Assert.IsTrue(result.Message == "Request is not well formed");
}
else
{
Assert.Fail($"Result value is null");
}
}
else
{
Assert.Fail($"Response is null");
}
}
// var result = (BaseResponse<object>)response.Value;
// if (result != null)
// {
// Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
// Console.WriteLine(JsonConvert.SerializeObject(result));
// Assert.IsTrue(result.Message == "Request is not well formed");
// }
// else
// {
// Assert.Fail($"Result value is null");
// }
// }
// else
// {
// Assert.Fail($"Response is null");
// }
// }
[TestMethod]
public async Task CreateUserAsync_Exception()