From 5c1eacd85e3803a72041128c0c4cefb73d8dae9a Mon Sep 17 00:00:00 2001 From: csimonapastore Date: Thu, 19 Jun 2025 19:45:02 +0200 Subject: [PATCH] Fixing sonarcloud issues --- .editorconfig | 8 -------- MainProject.Tests/Controllers/RoleController_Tests.cs | 2 +- MainProject.Tests/Controllers/UserController_Tests.cs | 2 +- .../Models/Api/Common/Role/UserRole_Tests.cs | 4 ++-- .../Models/Api/Common/User/AuthenticatedUser_Tests.cs | 6 +++--- MainProject/Controllers/AuthController.cs | 2 +- MainProject/Controllers/UserController.cs | 2 +- 7 files changed, 9 insertions(+), 17 deletions(-) diff --git a/.editorconfig b/.editorconfig index c9d40fe..b421b34 100644 --- a/.editorconfig +++ b/.editorconfig @@ -10,14 +10,6 @@ charset = utf-8 trim_trailing_whitespace = true insert_final_newline = true - -[*.cs] -dotnet_naming_style.pascal_case.capitalization = pascal_case -dotnet_naming_rule.types.symbols = types -dotnet_naming_rule.types.style = pascal_case -dotnet_naming_rule.types.severity = warning - - csharp_prefer_braced_block = true:suggestion csharp_preserve_single_line_blocks = true csharp_style_expression_bodied_methods = when_on_single_line:suggestion diff --git a/MainProject.Tests/Controllers/RoleController_Tests.cs b/MainProject.Tests/Controllers/RoleController_Tests.cs index ce2d797..75489e7 100644 --- a/MainProject.Tests/Controllers/RoleController_Tests.cs +++ b/MainProject.Tests/Controllers/RoleController_Tests.cs @@ -838,7 +838,7 @@ public class RoleController_Tests if (result != null) { Assert.AreEqual(StatusCodes.Status400BadRequest, result.Status); - Assert.IsTrue(result.Message == "This role is not editable"); + Assert.AreEqual("This role is not editable", result.Message); } else { diff --git a/MainProject.Tests/Controllers/UserController_Tests.cs b/MainProject.Tests/Controllers/UserController_Tests.cs index 71ef327..572f354 100644 --- a/MainProject.Tests/Controllers/UserController_Tests.cs +++ b/MainProject.Tests/Controllers/UserController_Tests.cs @@ -317,7 +317,7 @@ public class UserController_Tests if (result != null) { Assert.AreEqual(StatusCodes.Status400BadRequest, result.Status); - Assert.IsTrue(result.Message == "Invalid email"); + Assert.AreEqual("Invalid email", result.Message); } else { diff --git a/MainProject.Tests/Models/Api/Common/Role/UserRole_Tests.cs b/MainProject.Tests/Models/Api/Common/Role/UserRole_Tests.cs index f719dab..91f2779 100644 --- a/MainProject.Tests/Models/Api/Common/Role/UserRole_Tests.cs +++ b/MainProject.Tests/Models/Api/Common/Role/UserRole_Tests.cs @@ -23,9 +23,9 @@ public class UserRole_Tests try { DatabaseSqlServer.Role role = ModelsInit.CreateRole(); - UserRole userRole = new UserRole(role); + UserRole userRole = new(role); - Assert.IsTrue(userRole.Name == role.Name); + Assert.AreEqual(role.Name, userRole.Name); } catch (Exception ex) { diff --git a/MainProject.Tests/Models/Api/Common/User/AuthenticatedUser_Tests.cs b/MainProject.Tests/Models/Api/Common/User/AuthenticatedUser_Tests.cs index 0ef3de1..448aed2 100644 --- a/MainProject.Tests/Models/Api/Common/User/AuthenticatedUser_Tests.cs +++ b/MainProject.Tests/Models/Api/Common/User/AuthenticatedUser_Tests.cs @@ -25,9 +25,9 @@ public class AuthenticatedUser_Tests DatabaseSqlServer.User user = ModelsInit.CreateUser(); AuthenticatedUser authenticatedUser = new AuthenticatedUser(user); - Assert.IsTrue(authenticatedUser.FirstName == user.FirstName); - Assert.IsTrue(authenticatedUser.LastName == user.LastName); - Assert.IsTrue(authenticatedUser.Email == user.Email); + Assert.AreEqual(user.FirstName, authenticatedUser.FirstName); + Assert.AreEqual(user.LastName, authenticatedUser.LastName); + Assert.AreEqual(user.Email, authenticatedUser.Email); Assert.IsInstanceOfType(authenticatedUser.Role, typeof(UserRole)); } catch (Exception ex) diff --git a/MainProject/Controllers/AuthController.cs b/MainProject/Controllers/AuthController.cs index 9367729..bf8a891 100644 --- a/MainProject/Controllers/AuthController.cs +++ b/MainProject/Controllers/AuthController.cs @@ -32,7 +32,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers { try { - var data = await this._authService.AuthenticateAsync(request.Data); + var data = await this._authService.AuthenticateAsync(request!.Data); if (data == null) { diff --git a/MainProject/Controllers/UserController.cs b/MainProject/Controllers/UserController.cs index 72b46a7..32def4b 100644 --- a/MainProject/Controllers/UserController.cs +++ b/MainProject/Controllers/UserController.cs @@ -124,7 +124,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers return NotFound(); } - user = await this._userService.UpdateUserAsync(request.Data, user); + user = await this._userService.UpdateUserAsync(request!.Data, user); var userDto = _mapper?.Map(user);