Fixing sonarcloud issues

This commit is contained in:
2025-06-21 17:42:04 +02:00
parent 54a5106314
commit 4c3aa30cbb
10 changed files with 31 additions and 31 deletions

View File

@@ -30,7 +30,7 @@ public class RootController_Test
if (result != null) if (result != null)
{ {
var data = (OkResult)result; var data = (OkResult)result;
Assert.IsTrue(data.StatusCode == StatusCodes.Status200OK); Assert.AreEqual(StatusCodes.Status200OK, data.StatusCode);
} }
else else
{ {

View File

@@ -40,10 +40,10 @@ public class AutoMapperConfiguration_Tests
DatabaseSqlServer.User user = ModelsInit.CreateUser(); DatabaseSqlServer.User user = ModelsInit.CreateUser();
UserDto? data = _mapper?.Map<UserDto>(user); UserDto? data = _mapper?.Map<UserDto>(user);
Assert.IsTrue(data?.Guid == user.Guid); Assert.AreEqual(user.Guid, data?.Guid);
Assert.IsTrue(data?.FirstName == user.FirstName); Assert.AreEqual(user.FirstName, data?.FirstName);
Assert.IsTrue(data?.LastName == user.LastName); Assert.AreEqual(user.LastName, data?.LastName);
Assert.IsTrue(data?.Email == user.Email); Assert.AreEqual(user.Email, data?.Email);
} }
catch (Exception ex) catch (Exception ex)
{ {

View File

@@ -35,7 +35,7 @@ public class ApiResponse_Tests
try try
{ {
var baseResponse = new BaseResponse<object>(201, null, null); var baseResponse = new BaseResponse<object>(201, null, null);
Assert.IsFalse(baseResponse.Status == StatusCodes.Status200OK); Assert.AreNotEqual(StatusCodes.Status200OK, baseResponse.Status);
} }
catch (Exception ex) catch (Exception ex)
{ {

View File

@@ -39,7 +39,7 @@ public class AuthenticateResponse_Tests
try try
{ {
var authenticateResponse = new AuthenticateResponse(201, null, null); var authenticateResponse = new AuthenticateResponse(201, null, null);
Assert.IsFalse(authenticateResponse.Status == StatusCodes.Status200OK); Assert.AreNotEqual(StatusCodes.Status200OK, authenticateResponse.Status);
} }
catch (Exception ex) catch (Exception ex)
{ {

View File

@@ -54,7 +54,7 @@ public class GetRoleResponse_Tests
try try
{ {
var getRoleResponse = new GetRoleResponse(201, null, null); var getRoleResponse = new GetRoleResponse(201, null, null);
Assert.IsFalse(getRoleResponse.Status == StatusCodes.Status200OK); Assert.AreNotEqual(StatusCodes.Status200OK, getRoleResponse.Status);
} }
catch (Exception ex) catch (Exception ex)
{ {

View File

@@ -54,7 +54,7 @@ public class GetUserResponse_Tests
try try
{ {
var getUserResponse = new GetUserResponse(201, null, null); var getUserResponse = new GetUserResponse(201, null, null);
Assert.IsFalse(getUserResponse.Status == StatusCodes.Status200OK); Assert.AreNotEqual(StatusCodes.Status200OK, getUserResponse.Status);
} }
catch (Exception ex) catch (Exception ex)
{ {

View File

@@ -54,7 +54,7 @@ public class Settings_Tests
try try
{ {
var baseResponse = new BaseResponse<object>(201, null, null); var baseResponse = new BaseResponse<object>(201, null, null);
Assert.IsFalse(baseResponse.Status == StatusCodes.Status200OK); Assert.AreNotEqual(StatusCodes.Status200OK, baseResponse.Status);
} }
catch (Exception ex) catch (Exception ex)
{ {

View File

@@ -62,7 +62,7 @@ public class AuthService_Tests
if (authService != null) if (authService != null)
{ {
var authenticatedUser = await authService.AuthenticateAsync(request.Data); var authenticatedUser = await authService.AuthenticateAsync(request.Data);
Assert.IsTrue(authenticatedUser == null); Assert.IsNull(authenticatedUser);
} }
else else
{ {
@@ -93,7 +93,7 @@ public class AuthService_Tests
if (authService != null) if (authService != null)
{ {
var authenticatedUser = await authService.AuthenticateAsync(request.Data); var authenticatedUser = await authService.AuthenticateAsync(request.Data);
Assert.IsTrue(authenticatedUser == null); Assert.IsNull(authenticatedUser);
} }
else else
{ {

View File

@@ -53,7 +53,7 @@ public class JwtService_Tests
if (jwtService != null) if (jwtService != null)
{ {
var jwt = jwtService.GenerateToken(testString); var jwt = jwtService.GenerateToken(testString);
Assert.IsTrue(jwt != null); Assert.IsNotNull(jwt);
Assert.IsInstanceOfType(jwt, typeof(string)); Assert.IsInstanceOfType(jwt, typeof(string));
} }
else else

View File

@@ -94,7 +94,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetPermissionSystemByGuidAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetPermissionSystemByGuidAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {
@@ -117,7 +117,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetPermissionSystemByNameAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetPermissionSystemByNameAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {
@@ -139,7 +139,7 @@ public class PermissionService_Tests
var permission = await _permissionService.CreatePermissionSystemAsync(_permissionSystem.Name, true); var permission = await _permissionService.CreatePermissionSystemAsync(_permissionSystem.Name, true);
Assert.IsInstanceOfType(permission, typeof(PermissionSystem)); Assert.IsInstanceOfType(permission, typeof(PermissionSystem));
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsTrue(permission.Name == _permissionSystem.Name); Assert.AreEqual(_permissionSystem.Name, permission.Name);
Assert.IsTrue(permission.Enabled); Assert.IsTrue(permission.Enabled);
_permissionSystem = permission; _permissionSystem = permission;
@@ -210,7 +210,7 @@ public class PermissionService_Tests
var permission = await _permissionService.GetPermissionSystemByGuidAsync(_permissionSystem.Guid); var permission = await _permissionService.GetPermissionSystemByGuidAsync(_permissionSystem.Guid);
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsInstanceOfType(permission, typeof(PermissionSystem)); Assert.IsInstanceOfType(permission, typeof(PermissionSystem));
Assert.IsTrue(permission.Name == _permissionSystem.Name); Assert.AreEqual(_permissionSystem.Name, permission.Name);
Assert.IsTrue(permission.Enabled == _permissionSystem.Enabled); Assert.IsTrue(permission.Enabled == _permissionSystem.Enabled);
} }
else else
@@ -236,7 +236,7 @@ public class PermissionService_Tests
var permission = await _permissionService.GetPermissionSystemByNameAsync(_permissionSystem.Name); var permission = await _permissionService.GetPermissionSystemByNameAsync(_permissionSystem.Name);
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsInstanceOfType(permission, typeof(PermissionSystem)); Assert.IsInstanceOfType(permission, typeof(PermissionSystem));
Assert.IsTrue(permission.Guid == _permissionSystem.Guid); Assert.AreEqual(_permissionSystem.Guid, permission.Guid);
Assert.IsTrue(permission.Enabled == _permissionSystem.Enabled); Assert.IsTrue(permission.Enabled == _permissionSystem.Enabled);
} }
else else
@@ -265,7 +265,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetPermissionModuleByGuidAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetPermissionModuleByGuidAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {
@@ -288,7 +288,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetPermissionModuleByNameAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetPermissionModuleByNameAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {
@@ -310,7 +310,7 @@ public class PermissionService_Tests
var permission = await _permissionService.CreatePermissionModuleAsync(_permissionModule.Name, true); var permission = await _permissionService.CreatePermissionModuleAsync(_permissionModule.Name, true);
Assert.IsInstanceOfType(permission, typeof(PermissionModule)); Assert.IsInstanceOfType(permission, typeof(PermissionModule));
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsTrue(permission.Name == _permissionModule.Name); Assert.AreEqual(_permissionModule.Name, permission.Name);
Assert.IsTrue(permission.Enabled); Assert.IsTrue(permission.Enabled);
_permissionModule = permission; _permissionModule = permission;
@@ -383,7 +383,7 @@ public class PermissionService_Tests
var permission = await _permissionService.GetPermissionModuleByGuidAsync(_permissionModule.Guid); var permission = await _permissionService.GetPermissionModuleByGuidAsync(_permissionModule.Guid);
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsInstanceOfType(permission, typeof(PermissionModule)); Assert.IsInstanceOfType(permission, typeof(PermissionModule));
Assert.IsTrue(permission.Name == _permissionModule.Name); Assert.AreEqual(_permissionModule.Name, permission.Name);
Assert.IsTrue(permission.Enabled == _permissionModule.Enabled); Assert.IsTrue(permission.Enabled == _permissionModule.Enabled);
} }
else else
@@ -409,7 +409,7 @@ public class PermissionService_Tests
var permission = await _permissionService.GetPermissionModuleByNameAsync(_permissionModule.Name); var permission = await _permissionService.GetPermissionModuleByNameAsync(_permissionModule.Name);
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsInstanceOfType(permission, typeof(PermissionModule)); Assert.IsInstanceOfType(permission, typeof(PermissionModule));
Assert.IsTrue(permission.Guid == _permissionModule.Guid); Assert.AreEqual(_permissionModule.Guid, permission.Guid);
Assert.IsTrue(permission.Enabled == _permissionModule.Enabled); Assert.IsTrue(permission.Enabled == _permissionModule.Enabled);
} }
else else
@@ -438,7 +438,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetPermissionOperationByGuidAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetPermissionOperationByGuidAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {
@@ -461,7 +461,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetPermissionOperationByNameAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetPermissionOperationByNameAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {
@@ -483,7 +483,7 @@ public class PermissionService_Tests
var permission = await _permissionService.CreatePermissionOperationAsync(_permissionOperation.Name); var permission = await _permissionService.CreatePermissionOperationAsync(_permissionOperation.Name);
Assert.IsInstanceOfType(permission, typeof(PermissionOperation)); Assert.IsInstanceOfType(permission, typeof(PermissionOperation));
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsTrue(permission.Name == _permissionOperation.Name); Assert.AreEqual(_permissionOperation.Name, permission.Name);
_permissionOperation = permission; _permissionOperation = permission;
} }
@@ -536,7 +536,7 @@ public class PermissionService_Tests
var permission = await _permissionService.GetPermissionOperationByGuidAsync(_permissionOperation.Guid); var permission = await _permissionService.GetPermissionOperationByGuidAsync(_permissionOperation.Guid);
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsInstanceOfType(permission, typeof(PermissionOperation)); Assert.IsInstanceOfType(permission, typeof(PermissionOperation));
Assert.IsTrue(permission.Name == _permissionOperation.Name); Assert.AreEqual(_permissionOperation.Name, permission.Name);
} }
else else
{ {
@@ -561,7 +561,7 @@ public class PermissionService_Tests
var permission = await _permissionService.GetPermissionOperationByNameAsync(_permissionOperation.Name); var permission = await _permissionService.GetPermissionOperationByNameAsync(_permissionOperation.Name);
Assert.IsNotNull(permission); Assert.IsNotNull(permission);
Assert.IsInstanceOfType(permission, typeof(PermissionOperation)); Assert.IsInstanceOfType(permission, typeof(PermissionOperation));
Assert.IsTrue(permission.Guid == _permissionOperation.Guid); Assert.AreEqual(_permissionOperation.Guid, permission.Guid);
} }
else else
{ {
@@ -589,7 +589,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetPermissionSystemModuleByGuidAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetPermissionSystemModuleByGuidAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {
@@ -709,7 +709,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetPermissionSystemModuleOperationByGuidAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetPermissionSystemModuleOperationByGuidAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {
@@ -829,7 +829,7 @@ public class PermissionService_Tests
if (_permissionService != null) if (_permissionService != null)
{ {
var permission = await _permissionService.GetRolePermissionSystemModuleOperationByGuidAsync(Guid.NewGuid().ToString()); var permission = await _permissionService.GetRolePermissionSystemModuleOperationByGuidAsync(Guid.NewGuid().ToString());
Assert.IsTrue(permission == null); Assert.IsNull(permission);
} }
else else
{ {