simona/dotnet-template
Template
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing sonarcloud issues

Browse Source
This commit is contained in:
Caterina Simona Pastore
2025-06-19 00:53:52 +02:00
parent 8bc50f8135
commit 1fc8e6cc1c
4 changed files with 50 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
MainProject.Tests/Controllers/AuthController_Tests.cs
View File

@@ -61,7 +61,7 @@ public class AuthController_Tests
ObjectResult response = (ObjectResult)(await controller.AuthenticateAsync(request)); ObjectResult response = (ObjectResult)(await controller.AuthenticateAsync(request));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status200OK); Assert.AreEqual(StatusCodes.Status200OK, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -98,7 +98,7 @@ public class AuthController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -140,7 +140,7 @@ public class AuthController_Tests
if (response != null) if (response != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status404NotFound); Assert.AreEqual(StatusCodes.Status404NotFound, response.StatusCode);
} }
else else
{ {
@@ -168,7 +168,7 @@ public class AuthController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -207,13 +207,13 @@ public class AuthController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status500InternalServerError); Assert.AreEqual(StatusCodes.Status500InternalServerError, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError); Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError);
Assert.IsTrue(result.Message == "Something went wrong. Unexpected error"); Assert.AreEqual("Something went wrong. Unexpected error", result.Message );
} }
else else
{ {

58
MainProject.Tests/Controllers/RoleController_Tests.cs
View File

@@ -70,7 +70,7 @@ public class RoleController_Tests
ObjectResult response = (ObjectResult)(await _roleController.GetRoleByGuidAsync(guid)); ObjectResult response = (ObjectResult)(await _roleController.GetRoleByGuidAsync(guid));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status200OK); Assert.AreEqual(StatusCodes.Status200OK, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -105,7 +105,7 @@ public class RoleController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -141,7 +141,7 @@ public class RoleController_Tests
if (response != null) if (response != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status404NotFound); Assert.AreEqual(StatusCodes.Status404NotFound, response.StatusCode);
} }
else else
{ {
@@ -167,7 +167,7 @@ public class RoleController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -202,13 +202,13 @@ public class RoleController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status500InternalServerError); Assert.AreEqual(StatusCodes.Status500InternalServerError, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError); Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError);
Assert.IsTrue(result.Message == "Something went wrong. Unexpected error"); Assert.AreEqual("Something went wrong. Unexpected error", result.Message );
} }
else else
{ {
@@ -255,7 +255,7 @@ public class RoleController_Tests
ObjectResult response = (ObjectResult)(await _roleController.CreateRoleAsync(request)); ObjectResult response = (ObjectResult)(await _roleController.CreateRoleAsync(request));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status200OK); Assert.AreEqual(StatusCodes.Status200OK, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -297,13 +297,13 @@ public class RoleController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest); Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
Assert.IsTrue(result.Message == "Invalid name"); Assert.AreEqual("Invalid name", result.Message );
} }
else else
{ {
@@ -341,7 +341,7 @@ public class RoleController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -391,7 +391,7 @@ public class RoleController_Tests
ObjectResult response = (ObjectResult)(await _roleController.CreateRoleAsync(request)); ObjectResult response = (ObjectResult)(await _roleController.CreateRoleAsync(request));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -441,7 +441,7 @@ public class RoleController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -494,13 +494,13 @@ public class RoleController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status500InternalServerError); Assert.AreEqual(StatusCodes.Status500InternalServerError, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError); Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError);
Assert.IsTrue(result.Message == "Something went wrong. Unexpected error"); Assert.AreEqual("Something went wrong. Unexpected error", result.Message );
} }
else else
{ {
@@ -531,7 +531,7 @@ public class RoleController_Tests
ObjectResult response = (ObjectResult)(await _roleController.DeleteRoleByGuidAsync(guid)); ObjectResult response = (ObjectResult)(await _roleController.DeleteRoleByGuidAsync(guid));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status200OK); Assert.AreEqual(StatusCodes.Status200OK, response.StatusCode);
} }
else else
{ {
@@ -555,7 +555,7 @@ public class RoleController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -591,7 +591,7 @@ public class RoleController_Tests
if (response != null) if (response != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status404NotFound); Assert.AreEqual(StatusCodes.Status404NotFound, response.StatusCode);
} }
else else
{ {
@@ -617,7 +617,7 @@ public class RoleController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -652,13 +652,13 @@ public class RoleController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status500InternalServerError); Assert.AreEqual(StatusCodes.Status500InternalServerError, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError); Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError);
Assert.IsTrue(result.Message == "Something went wrong. Unexpected error"); Assert.AreEqual("Something went wrong. Unexpected error", result.Message );
} }
else else
{ {
@@ -708,7 +708,7 @@ public class RoleController_Tests
ObjectResult response = (ObjectResult)(await _roleController.UpdateRoleAsync(request, role.Guid)); ObjectResult response = (ObjectResult)(await _roleController.UpdateRoleAsync(request, role.Guid));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status200OK); Assert.AreEqual(StatusCodes.Status200OK, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -752,7 +752,7 @@ public class RoleController_Tests
if (response != null) if (response != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status404NotFound); Assert.AreEqual(StatusCodes.Status404NotFound, response.StatusCode);
} }
else else
{ {
@@ -786,13 +786,13 @@ public class RoleController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest); Assert.IsTrue(result.Status == StatusCodes.Status400BadRequest);
Assert.IsTrue(result.Message == "Invalid name"); Assert.AreEqual("Invalid name", result.Message );
} }
else else
{ {
@@ -832,7 +832,7 @@ public class RoleController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -874,7 +874,7 @@ public class RoleController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -922,7 +922,7 @@ public class RoleController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -976,13 +976,13 @@ public class RoleController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status500InternalServerError); Assert.AreEqual(StatusCodes.Status500InternalServerError, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError); Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError);
Assert.IsTrue(result.Message == "Something went wrong. Unexpected error"); Assert.AreEqual("Something went wrong. Unexpected error", result.Message );
} }
else else
{ {

28
MainProject.Tests/Controllers/UserController_Tests.cs
View File

@@ -80,7 +80,7 @@ public class UserController_Tests
ObjectResult response = (ObjectResult)(await _userController.GetUserByGuidAsync(guid)); ObjectResult response = (ObjectResult)(await _userController.GetUserByGuidAsync(guid));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status200OK); Assert.AreEqual(StatusCodes.Status200OK, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -115,7 +115,7 @@ public class UserController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -151,7 +151,7 @@ public class UserController_Tests
if (response != null) if (response != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status404NotFound); Assert.AreEqual(StatusCodes.Status404NotFound, response.StatusCode);
} }
else else
{ {
@@ -177,7 +177,7 @@ public class UserController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -212,13 +212,13 @@ public class UserController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status500InternalServerError); Assert.AreEqual(StatusCodes.Status500InternalServerError, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError); Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError);
Assert.IsTrue(result.Message == "Something went wrong. Unexpected error"); Assert.AreEqual("Something went wrong. Unexpected error", result.Message );
} }
else else
{ {
@@ -265,7 +265,7 @@ public class UserController_Tests
ObjectResult response = (ObjectResult)(await _userController.CreateUserAsync(request)); ObjectResult response = (ObjectResult)(await _userController.CreateUserAsync(request));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status200OK); Assert.AreEqual(StatusCodes.Status200OK, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -311,7 +311,7 @@ public class UserController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -362,7 +362,7 @@ public class UserController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -407,7 +407,7 @@ public class UserController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -462,7 +462,7 @@ public class UserController_Tests
ObjectResult response = (ObjectResult)(await _userController.CreateUserAsync(request)); ObjectResult response = (ObjectResult)(await _userController.CreateUserAsync(request));
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
@@ -515,7 +515,7 @@ public class UserController_Tests
// if (response != null && response.Value != null) // if (response != null && response.Value != null)
// { // {
// Assert.IsTrue(response.StatusCode == StatusCodes.Status400BadRequest); // Assert.AreEqual(StatusCodes.Status400BadRequest, response.StatusCode);
// var result = (BaseResponse<object>)response.Value; // var result = (BaseResponse<object>)response.Value;
// if (result != null) // if (result != null)
@@ -577,13 +577,13 @@ public class UserController_Tests
if (response != null && response.Value != null) if (response != null && response.Value != null)
{ {
Assert.IsTrue(response.StatusCode == StatusCodes.Status500InternalServerError); Assert.AreEqual(StatusCodes.Status500InternalServerError, response.StatusCode);
var result = (BaseResponse<object>)response.Value; var result = (BaseResponse<object>)response.Value;
if (result != null) if (result != null)
{ {
Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError); Assert.IsTrue(result.Status == StatusCodes.Status500InternalServerError);
Assert.IsTrue(result.Message == "Something went wrong. Unexpected error"); Assert.AreEqual("Something went wrong. Unexpected error", result.Message );
} }
else else
{ {

2
MainProject/Controllers/UserController.cs
View File

@@ -71,7 +71,7 @@ namespace BasicDotnetTemplate.MainProject.Controllers
{ {
try try
{ {
if (await this._userService.CheckIfEmailIsValid(request.Data.Email)) if (await this._userService.CheckIfEmailIsValid(request!.Data!.Email))
{ {
var role = await this._roleService.GetRoleForUser(request.Data.RoleGuid); var role = await this._roleService.GetRoleForUser(request.Data.RoleGuid);
if (role == null) if (role == null)