From 114e7c7c501259e471c2f68701174830e5619c90 Mon Sep 17 00:00:00 2001 From: csimonapastore Date: Sun, 2 Mar 2025 17:59:12 +0100 Subject: [PATCH] Improving code coverage - wip --- .../Controllers/AuthController_Tests.cs | 35 +++++++++++++++++++ MainProject/Controllers/AuthController.cs | 5 --- 2 files changed, 35 insertions(+), 5 deletions(-) diff --git a/MainProject.Tests/Controllers/AuthController_Tests.cs b/MainProject.Tests/Controllers/AuthController_Tests.cs index 352a4a2..2326515 100644 --- a/MainProject.Tests/Controllers/AuthController_Tests.cs +++ b/MainProject.Tests/Controllers/AuthController_Tests.cs @@ -91,4 +91,39 @@ public class AuthController_Tests } } + [TestMethod] + public async Task AuthenticateAsync_AuthenticateRequestDataNull() + { + IConfiguration configuration = TestUtils.CreateConfiguration(); + var authServiceMock = new Mock(); + var controller = new AuthController(configuration, authServiceMock.Object); + + var request = new AuthenticateRequest + { + Data = null + }; + authServiceMock.Setup(s => s.AuthenticateAsync(It.IsAny())).ReturnsAsync((AuthenticatedUser)null); + ObjectResult response = (ObjectResult)(await controller.AuthenticateAsync(request)); + + if(response != null && response.Value != null) + { + Assert.IsTrue(response.StatusCode == 400); + + var result = (BaseResponse)response.Value; + if(result != null) + { + Assert.IsTrue(result.Status == 400); + Assert.IsTrue(result.Message == "Request is not well formed"); + } + else + { + Assert.Fail($"Result value is null"); + } + } + else + { + Assert.Fail($"Response value is null"); + } + } + } diff --git a/MainProject/Controllers/AuthController.cs b/MainProject/Controllers/AuthController.cs index bdf070f..69b39ac 100644 --- a/MainProject/Controllers/AuthController.cs +++ b/MainProject/Controllers/AuthController.cs @@ -30,11 +30,6 @@ namespace BasicDotnetTemplate.MainProject.Controllers { try { - if (!ModelState.IsValid) - { - return BadRequest("Request is not well formed"); - } - if ( request == null || request.Data == null ||