From 030882f3e18cf49c3b837d5e71691858d4ec1e39 Mon Sep 17 00:00:00 2001 From: csimonapastore Date: Sun, 23 Mar 2025 22:37:10 +0100 Subject: [PATCH] Fixing test coverage for CreateUserAsync --- MainProject.Tests/Services/UserService_Tests.cs | 9 +++++---- MainProject/Services/UserService.cs | 2 ++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/MainProject.Tests/Services/UserService_Tests.cs b/MainProject.Tests/Services/UserService_Tests.cs index 530f6cc..4a893d6 100644 --- a/MainProject.Tests/Services/UserService_Tests.cs +++ b/MainProject.Tests/Services/UserService_Tests.cs @@ -1,6 +1,7 @@ using BasicDotnetTemplate.MainProject.Services; using BasicDotnetTemplate.MainProject.Models.Api.Data.User; using BasicDotnetTemplate.MainProject.Models.Database.SqlServer; +using Microsoft.EntityFrameworkCore; namespace BasicDotnetTemplate.MainProject.Tests; @@ -37,7 +38,7 @@ public class UserService_Tests var userService = TestUtils.CreateUserService(); var user = ModelsInit.CreateUser(); var role = ModelsInit.CreateRole(); - CreateUserRequestData data = new CreateUserRequestData() + CreateUserRequestData data = new() { FirstName = user.FirstName, LastName = user.LastName, @@ -50,12 +51,12 @@ public class UserService_Tests Assert.IsNotNull(createdUser); // Act - var retrievedUser = await userService.GetUserByIdAsync(createdUser.Id); + var retrievedUser = await userService.GetUserByIdAsync(createdUser!.Id); Assert.IsNotNull(retrievedUser); // Assert - Assert.AreEqual(createdUser.Id, retrievedUser.Id); - Assert.AreEqual(createdUser.Guid, retrievedUser.Guid); + Assert.AreEqual(createdUser!.Id, retrievedUser!.Id); + Assert.AreEqual(createdUser!.Guid, retrievedUser!.Guid); } } diff --git a/MainProject/Services/UserService.cs b/MainProject/Services/UserService.cs index d88cf34..1c9b99b 100644 --- a/MainProject/Services/UserService.cs +++ b/MainProject/Services/UserService.cs @@ -124,7 +124,9 @@ public class UserService : BaseService, IUserService } catch (Exception exception) { + await transaction.RollbackAsync(); Logger.Error(exception, $"[UserService][CreateUserAsync]"); + throw; }